GijsTempel / care-up

CareUp Game
0 stars 0 forks source link

Change workfield position #1849

Closed Mbaarda closed 1 year ago

Mbaarda commented 3 years ago

We need to change the position of the workfield closer to the cliënt. Because when you do a protocol, you should make it as easy as possible for yourself. (And not walk back and forth 20 times) So to make CareUp abit more realistic we should move the workfield closer to the cliënt.

Objects positions change: (Normal)

Objects positions change (inhouse)

It should look something like this: image.png

image.png

image.png

image.png

We also have to think about the position of the cliënt and player, when he/she is standing next to bed. When the player has to greet the cliënt at the beginning of the scene, it wil become a litte narrow. Maybe this doesnt matter we can test this first and see what happens. I think you wont even see the workfield when you are at the client for greeting etc.

PeterHarmatiy commented 3 years ago

Did some tests and found out, that changing positions won't cause any bad consequences on the animation side. All should work prefect. I tired to change position in the Injection Subcutaneous hospital scene, and it looks ok. View from the workfield position: image.png View from the patient's position: image.png No any wrong overlays or something that can be wrong on visual side. So in all injection hospital scenes changing position can be done easily. Don't know if it has sense to change something in injection inhouse scenes. Because there patient is sitting on chair that is near the table. Or, as an option, we can assign as a workfied a coffee table. image.png

In the other scenes there can be some minor issues in changing position because some of them have animations which interact with environment, like closing curtains ( in that case player will go through the table in hospital scenes), moving chair in bandaging scenes, walking patient to sink in glucose measuring scene, preparing pump in feeding with pump scene. So in these scenes we will need to adjust such animations.

About major problems: Some part of our UI code and hint system are connected to angles and positions in scene. That's why we will need to adjust it, because it will throw errors and cause freezes. image.png

About position near the patient in the inhouse scenes with a second room, even old position looks ok and table is slightly visible but I think it's not a problem: image.png

So for now I'll start changing an injection scenes, and after will work with the rest.

PeterHarmatiy commented 3 years ago

Changed all injection scenes where patient is present Here the example of insulin injection scene. Check please if all are as you expected or something should be changed: https://youtu.be/99QVV803tAU

PeterHarmatiy commented 3 years ago

Changed scenes:

PeterHarmatiy commented 3 years ago

Finished changing all hospital scenes where the patient is present. Ready to check in the ChangeWorkfieldPosition branch. Or, if needed, I can record a video of passing each protocol with the new workfield position.

Mbaarda commented 3 years ago

Awesome Peter! Nice! No need to record it all. Ill test all the scenes with the interns here :)

About the inhouse scene: The table is slightly visible but that is no problem as you said. The table in the living room is close enough at the cliënt so no changes needed here. (If cliënt is sitting in chair)

PeterHarmatiy commented 3 years ago

Finished changing all scenes which need it. During the work process, I faced with moments that need small clarification:

  1. Where would you like to place the starting position of a player in changed inhouse scenes ? (Player's position at the start of the scene).
  2. At the moment in the inhouse scenes there is an animation of walking from one room to another (from table to patient, if this is the first time). Should this animation be removed or we should leave it but modify in some way?
  3. Do we need to change workfield positions in hospital scenes where there is no patient? (Medication preparation, cleaning hands with alcohol)
PeterHarmatiy commented 3 years ago

I've tried different positions and variations of spawn position and came to this result: https://youtu.be/aWkCpRbZBzQ So after loading the scene, player will see an animation of walking to the bedroom and on the point when the animation stops there will be a spawn position. From that position we can clearly see a workfield and a patient.

Mbaarda commented 3 years ago
  1. Where would you like to place the starting position of a player in changed inhouse scenes ? (Player's position at the start of the scene). The walk animation is looking good! The animation only needs to be played once, in the beginning, so this is done :) Walk animation is only needed in the inhouse scenes where we use the cliënts bedroom. But you already knew this :)

  2. At the moment in the inhouse scenes there is an animation of walking from one room to another (from table to patient, if this is the first time). Should this animation be removed or we should leave it but modify in some way? You already fixed this, thanks.

  3. Do we need to change workfield positions in hospital scenes where there is no patient? (Medication preparation, cleaning hands with alcohol) No, its good for the variety. So the workfield can stay in the same position in those scenes :)

PeterHarmatiy commented 3 years ago

Did all the necessary changes that were left. Tested all the scenes, seems they are ready now. Did not find any significant errors (except those which already are posted on the board).