search

GijsTimmers / kotnetcli

An easy automated way to log in on Kotnet.
GNU General Public License v3.0
5 stars 4 forks source link

Store institution choice in credentials #114

Closed jovanbulck closed 8 years ago

jovanbulck commented 8 years ago

Proposal: same user will always login with the same institution, so we might as well remember the choice and store it alongside username/pwd in the Credentials back-end. When prompting the user for credentials the first time, or in guest mode, the institution name should also be queried.

This is easier and more elegant than passing a command line option, or configuring an alias to do so.

GijsTimmers commented 8 years ago

First off, good idea. This will be useful in most cases, but not always.

See also #113. Suppose that a user takes his laptop to a library or another KU Leuven building. Also suppose that he hasn't configured his laptop to connect to eduroam and he wants to connect to kuleuven-guest instead. In that case, he'd have to use guest-mode which is a bit strange.

Proposal: store institution choice in credentials, but allow it to be overridden by the --institution flag.

jovanbulck commented 8 years ago

Done!

GijsTimmers commented 8 years ago

Haha great stuff!