Colorama communicator restructuring

GijsTimmers / kotnetcli

An easy automated way to log in on Kotnet.

GNU General Public License v3.0

5 stars 4 forks source link

Colorama communicator restructuring #52

Closed jovanbulck closed 9 years ago

jovanbulck commented 9 years ago

DialogCommunicator now handles the eventSamenvatting:

screenshot from 2014-12-29 11 51 22

Sorry for the trailing space removal of atom again. I'll have to look into this next time...

I's a quick hack however. See last comment in issue #49 for a proposed alternative

GijsTimmers commented 9 years ago

OK, thank you for taking the time in this busy period. eventSamenvattingGeven() is not a real necessity at the moment, so if this is just a quick hack, we should consider refactoring the code altogether, as you proposed in #49.

jovanbulck commented 9 years ago

Ok :+1:

We'll see then when implementing the factory pattern in #49 . The general idea of this pull request, using self.msg to display additional msg in the dialog is ok though. So that should easily be integrated in a LoginDialogCommunicator and/or LogoutDialogCommunicator

jovanbulck commented 9 years ago

@GijsTimmers Apparently I pushed into this open pull request, but the original eventSamenvatting is gone so it's ok I think...

Added some small comment questions in communicator.py
minor enhancement to the bubblecommunicator: more elegant createAndShowNotification method in superclass
major restructuring of the plaintext and colorama communicator to avoid code duplication and facilitate overriding appearance Check it out
changed some lines in kotnetcli.py in order to be able to test; you should maybe consider a dev branch, so the master remains working ;-)

GijsTimmers commented 9 years ago

Please checkout to the dev branch for work.