search

GijsTimmers / kotnetcli

An easy automated way to log in on Kotnet.
GNU General Public License v3.0
5 stars 4 forks source link

Elegant logging using the logging module #59

Closed GijsTimmers closed 8 years ago

GijsTimmers commented 9 years ago

Debug stuff like ik wil bellen blazen should be elegantly logged using the python logging module.

We will work on this when kotnetcli 2.0.0 is released.

jovanbulck commented 9 years ago

implemented basic idea, linked above; added --debug option (toggled on by default in kotnetcli_test.py)

screenshot from 2015-02-13 16 57 49 screenshot from 2015-02-13 16 59 50

GijsTimmers commented 9 years ago

Exactly. Nice job!

jovanbulck commented 9 years ago

note: whereas logging of setup-errors (eg import failed or so) is fine, we should better not use the logging system to provide users with login-procedure (i.e. worker) errors (as I did in the above commits)

Instead, we should think about changing the communicator API with error feedback methods

GijsTimmers commented 9 years ago

Yes, just use the communicator for expected errors, and use the logging module for more detail on what's happening.

jovanbulck commented 8 years ago

Yes, just use the communicator for expected errors, and use the logging module for more detail on what's happening.

Done #106