search

Gilead-BioStats / gsm

Good Statistical Monitoring R Package
https://gilead-biostats.github.io/gsm/
Apache License 2.0
39 stars 10 forks source link

Feature: Use `{renv}` #1395

Closed mattroumaya closed 1 month ago

mattroumaya commented 1 year ago

Feature Details

jwildfire commented 8 months ago

@mattroumaya is this still needed? can you provide a few notes on implementation possibilities.

cc: @dpastoor

jonthegeek commented 4 months ago

@jwildfire My vote would be no for this. {renv} is great for users who want to produce reproducible results, but the DESCRIPTION file should capture requirements for packages. The only potential use case I can imagine would be something around workflows (if they might require packages that {gsm} itself doesn't), but I don't think that applies.

samussiah commented 4 months ago

@jonthegeek - generally speaking should all Imports have an associated minimum version?

jonthegeek commented 4 months ago

@samussiah Ideally, yes. There was an experimental posit project (or I think it was still Rstudio, technically) to make it ~easy to figure out the minimum version you need based on functions and arguments, but I think it was too tricky and they abandoned it.

So if we want to capture minimum versions of everything... technically renv can kinda help, but it would just be using whatever version we happened to have installed and saying they're the minimum. If we're just going to do that, we can usethis::use_package(..., min_version = TRUE) our way through the current requirements, but I think it would be better to take the time to figure out true minimum versions. I think I could probably set up either something locally or a GHA thing that could figure these out, but it would take time to work through the logic.