Feature: Replace dfParams with vThreshold in all charts

Gilead-BioStats / gsm

Good Statistical Monitoring R Package

https://gilead-biostats.github.io/gsm/

Apache License 2.0

39 stars 9 forks source link

Feature: Replace dfParams with vThreshold in all charts #1596

Closed jwildfire closed 4 months ago

jwildfire commented 4 months ago

Feature Details

Just pass threshold values to widgets instead of a more complex data frame

Example Code

Possible Implementation

Additional Comments

jwildfire commented 4 months ago

Need to sort out relation to #1595

jwildfire commented 4 months ago

@samussiah @taylorrodgers - Has rbm-viz v1.2 been updated to expect a simple vThreshold object for bar charts and longitudinal charts? Or is it still expecting the old dfParams structure per the wiki?

taylorrodgers commented 4 months ago

@jwildfire @samussiah , would that be this ticket here?

If so, it has not been done yet.

lauramaxwell commented 4 months ago

closed with #1609