Gilead-BioStats / gsm

Good Statistical Monitoring R Package
https://gilead-biostats.github.io/gsm/
Apache License 2.0
36 stars 9 forks source link

Feature: move dfBounds creation to reporting pipeline only #1670

Closed lauramaxwell closed 1 month ago

lauramaxwell commented 1 month ago

Feature Details

create dfBoundsfrom dfResultsso that we only have one version of dfBounds, instead of the current setup where we have analyticsBoundsand reportingBounds (but both are called dfBounds)

Example Code

Possible Implementation

update the workflow/metrics yamls to not create dfBounds, and update data_reporting.yaml and analyze_NormalApprox_predictBounds() to create reporting version of dfBoundswith dfResults as the input

Additional Comments

jwildfire commented 1 month ago

Going to add Type to the workflow.meta as part of this. May also rename strThreshold to just Threshold to standardize naming.