search

Gilead-BioStats / gsm

Good Statistical Monitoring R Package
https://gilead-biostats.github.io/gsm/
Apache License 2.0
36 stars 9 forks source link

Feature: Rename dfMetrics$strThreshold to dfMetrics$Threshold #1674

Closed jwildfire closed 1 month ago

jwildfire commented 1 month ago

Feature Details

Remove str to standardize naming in dfMetrics. Start with updating meta$strThresholds headers in inst/workflow/metrics and then propagate through function calls and update gsm$reportingMetrics

Example Code

Possible Implementation

Additional Comments

jwildfire commented 1 month ago

@lauramaxwell @jonthegeek Simple one to pick up either in 2.0 or 2.1

jonthegeek commented 1 month ago

Relevant note about this from @lauramaxwell:

I didn't edit strThreshold to be Threshold in the meta because since there is a string version and a vector version of Threshold in the workflow, I think it is useful to make clear which is which. open to discussion on this though!