Gilead-BioStats / gsm

Good Statistical Monitoring R Package
https://gilead-biostats.github.io/gsm/
Apache License 2.0
36 stars 9 forks source link

Feature: Refactor Local/Global Site select in report #1689

Open jwildfire opened 1 month ago

jwildfire commented 1 month ago

Feature Details

image

Having 2 site selects is a bit confusing. I think we should just delete the local "Highlight Site" control and use the global "Select Group" control exclusively.

Example Code

Possible Implementation

Additional Comments

taylorrodgers commented 1 month ago

Just want to comment that this would be ideal for the overview table widget as well. :)

samussiah commented 1 month ago

@taylorrodgers - are you thinking the overall group select subsets the overview table as well?

taylorrodgers commented 1 month ago

@taylorrodgers - are you thinking the overall group select subsets the overview table as well?

@samussiah I think I commented on this in error and forgot to delete. This was in relation to the Site SubSet drop down on the overview table, which was not the same as selecting a site id.