search

Gilead-BioStats / gsm

Good Statistical Monitoring R Package
https://gilead-biostats.github.io/gsm/
Apache License 2.0
39 stars 9 forks source link

Closes #1653 adds Flag Over Time Widget to Study Overview as a tab #1850

Closed zdz2101 closed 2 months ago

zdz2101 commented 2 months ago

Overview

Mimic the Visualize_Metric() / Report_MetricCharts() and like-kind that generate the tabbed portions of Results section in the KRI report but for: Group Overview and Flag Over Time under Study Overview

zdz2101 commented 2 months ago

image

image

Tabulated form of Study Overview is ready-ish, or certainly a working rough draft is available. Couple points to raise though:

  1. For the Flag Over Time visualization, it seems that this can blow up in size/ability to render (see top image orange circle to give an idea how much scrolling may be done), as there are up to (m n p) boxes, where m is number of sites, n is number of kri's and p is number of timepoints (see bottom image, would be inserted where top image yellow arrow is)
  2. My ability to run example 3.3 Site-Level KRI Report locally was shaky, sometimes it would crash sometimes not, I had to use the filtered snapshot date for the top image to check the tabs actually work, obviously this is will dependent on hardware capabilities or whatever is running this report
  3. It may be more useful to limit what is actually displayed in the Flag Over Time visualization, perhaps display New Flag? rows only? Further discussion needed

@lauramaxwell @jwildfire

lauramaxwell commented 2 months ago

We could also potentially filter on "Any flag in most recent period", which would include new flags and unresolved flags. This might be a question for the user group, to ensure we meet their requirements.

jwildfire commented 2 months ago

How about if we just drop rows that have no flags at any time point? and add a footnote saying that only sites with at least one flag are shown. I think that would drop well over half of the rows and should make the table more manageable.

I guess we do need to be a little bit aware of file size/performance issues here. If the report gets larger than a couple mb, we'll start seeing issues with load time.

zdz2101 commented 2 months ago

Shaving it down to not-all-green rows certainly did the trick for rendering on my end locally image