Gilead-BioStats / gsm

Good Statistical Monitoring R Package
https://gilead-biostats.github.io/gsm/
Apache License 2.0
39 stars 9 forks source link

Bugfix: allow for more complex specs to be checked properly #1900

Closed lauramaxwell closed 1 month ago

lauramaxwell commented 1 month ago

Expected Behavior

users should be able to require _all columns of a given df, and also specify type for specific columns in specs and checkSpec() will check those columns appropriately, See below for example spec.

image

Current Behavior

right now checkSpec() doesn't check those columns because _all is used for required, so it currently skips the type step as well due to some faulty logic.

Possible Solution

updated logic in checkSpec to

Steps to Reproduce

1. 2. 3. 4.

Context (Environment)

Possible Implementation

Additional Comments