Gilead-BioStats / gsm

Good Statistical Monitoring R Package
https://gilead-biostats.github.io/gsm/
Apache License 2.0
39 stars 9 forks source link

Update `Metrics.yaml` to not generate `lWorkflows` within steps #1930

Closed lauramaxwell closed 2 weeks ago

lauramaxwell commented 3 weeks ago

Overview

lWorkflows should be based on the current module/study being run, not always just the gsm workflows. This simply updates the flow to take an lWorkflows argument in the lData list in RunWorkflows() to run Metrics.yaml properly.

Note: lWorkflows was already being fed into RunWorkflows() in this way, so this is not an update to process, just a simplification.

Test Notes/Sample Code

Connected Issues

lauramaxwell commented 2 weeks ago

The changes made here look good, comment isn't related to this issue but the 3_reporting directory in general too, the results.yaml in this workflow runs Sys.date() as the snapshot date because that's the default set in BindResults, wondering if we should make it more "clear" / bring it forward to the results.yaml as well

image

added an issue to revisit defaults on some of these util functions