Bootstrap 4 compatibility

[JayHuang]

Right now Bootstrap 4 is still in alpha but it's worth noting some of the changes that will affect this project.

2 of the changes I've run into so far:

• Glyphicons are no longer included with Bootstrap (documented)
• .btn-default has been dropped, replaced with .btn-secondary (?, undocumented)

Example of how the datetimepicker looks with Bootstrap 4 Alpha (affected by both items listed):

[Gillardo]

Thanks for the heads up.

Is bootstrap 4 use able in a site yet? If so then I may upgrade a development site I have to v4 to find all changes and then I will create a v4 version of the datetime picker which I can use as well.

Also waiting for angular 2.0 to become "stable" so I can do the same with that too... On 9 Sep 2015 2:36 am, "Jay Huang" notifications@github.com wrote:

Right now Bootstrap 4 is still in alpha but it's worth noting some of the changes that will affect this project.

2 of the changes I've run into so far:

• Glyphicons are no longer included with Bootstrap (documented)
• .btn-default has been dropped, replaced with .btn-secondary (?, undocumented)

— Reply to this email directly or view it on GitHub https://github.com/Gillardo/bootstrap-ui-datetime-picker/issues/46.

[Gillardo]

I dont use glyphicons anyway, so i run a grunt task to replace glyphicons with fa upon build, you have convinced me to download bootstrap 4 now :)

[Gillardo]

Can i ask how you are downloading bootstrap 4, do you use bower? If so, whats the install because bower install just installs boostrap 3

[JayHuang]

(: happy to hear that. Try "~4.0.0-alpha" in bower config, works for me.

[Gillardo]

Downloaded it, but couldnt get the navbar to work with dropdowns?

On Wed, Sep 9, 2015 at 4:53 PM, Jay Huang notifications@github.com wrote:

(: happy to hear that. Try "~4.0.0-alpha" in bower config, works for me.

— Reply to this email directly or view it on GitHub https://github.com/Gillardo/bootstrap-ui-datetime-picker/issues/46#issuecomment-138954841 .

[Gillardo]

Need that to work in my current project and no info on document pages about it.... if u know how to do this pls let me know and I will give it another shot On 9 Sep 2015 4:57 pm, "Darren Gillard" darren.gillard81@gmail.com wrote:

Downloaded it, but couldnt get the navbar to work with dropdowns?

On Wed, Sep 9, 2015 at 4:53 PM, Jay Huang notifications@github.com wrote:

(: happy to hear that. Try "~4.0.0-alpha" in bower config, works for me.

— Reply to this email directly or view it on GitHub https://github.com/Gillardo/bootstrap-ui-datetime-picker/issues/46#issuecomment-138954841 .

[JayHuang]

It has some issues out of the box with my navbar also, but I don't believe that affects datetimepicker? Should only be the two changes I listed initially. Right now I just append the equivalent font awesome class and .btn-secondary along with the glyphicon so it works for both.

Example:

<button type="button" class="btn btn-default btn-secondary" ng-click="open($event)">
    <i class="glyphicon glyphicon-calendar fa fa-calendar"></i>
</button>

[Gillardo]

No navbar doesn't effect datetime picker but I need it working in my project so can proceed until it's working yet On 9 Sep 2015 11:24 pm, "Jay Huang" notifications@github.com wrote:

It has some issues out of the box with my navbar also, but I don't believe that affects datetimepicker? Should only be the two changes I listed initially. Right now I just append the equivalent font awesome class and .btn-secondary along with the glyphicon so it works for both.

— Reply to this email directly or view it on GitHub https://github.com/Gillardo/bootstrap-ui-datetime-picker/issues/46#issuecomment-139062190 .

[JayHuang]

The only change I needed to do to get mine to look the same was add .nav-item to every li element in the navbar. See http://v4-alpha.getbootstrap.com/components/navbar/ for Bootstrap 4 navbar docs.

[ParaBolt]

I've been using this plugin with ui-bootstrap4 and did not have to make any changes.