search

Gillardo / ngx-bootstrap-datetime-popup

Date and time picker using ngx-bootstrap library
MIT License
31 stars 14 forks source link

ModuleWithProviders type without a generic type argument #35

Closed sbaumohl closed 4 years ago

sbaumohl commented 4 years ago

In order for this library to be compatible for Angular 9, ModuleWithProviders requires a generic argument.

More can be read here

syedyawar commented 4 years ago

Please fix and update this on npm

Gillardo commented 4 years ago

This is already done I just need to do one last thing before uploading it to npm

Gillardo commented 4 years ago

But the library still works with angular 9 as I am using it in my project running angular 9.1.0 and it works fine

syedyawar commented 4 years ago

But the library still works with angular 9 as I am using it in my project running angular 9.1.0 and it works fine

I'm on angular 9.1.3, at first, i'm having the same error, but then I remove and again install this package and boom,error gone

sbaumohl commented 4 years ago

seems like @Gillardo fixed and merged this, so I'll close this.

Gillardo commented 4 years ago

I have fixed it, but i cant publish it atm because i cannot get the gh-pages command to work to create the demo site on github