GillesArcas / Drago

The Swiss army knife for the game of Go: game editor, game database, game replayer, game exporter, game engine client
http://www.godrago.net
MIT License
19 stars 6 forks source link

Korean text fails to render #2

Open comiluv opened 3 years ago

comiluv commented 3 years ago

OS: Windows 10 Korean version (20H2 build 19042.1052) Drago version: 4.30, 4.31

Drago displays incorrect, broken characters when language is set to use Korean

Screenshots below. Red annotations indicate broken text display

drago1 drago2 drago3 drago4

Note: Bug doesn't happen in version 4.23

comiluv commented 3 years ago

Continuing from #4,

Hi, PR accepted. Now the question is when to make a 4.32 with your translation and fixing your problem. I have two problems with that. First, I am currently traveling for three months (until beginning of September). I have a tiny computer with the development environment and I can compile and make a release but it is a little bit more complicated. And second, I see no issue from here and the UI seems correctly translated. For this reason, I am left with no clues for where to start. Perhaps you could determine if it is a code issue or an install issue by installing portable versions for 4.23 and 4.31 and putting the exe file from 4.31 in 4.23 directory and see what happens, or exchange Languages directory , or things like that. Tell me also if they are parts witch are correctly translated. I am comparing the files from both versions to see if I find any reason for the bug without any idea until now. I am sorry to not being able to do more for the moment.

Image1

Screenshots 1 2 3 4 5 6 7 8 9 10

I hope you travel safely, in this troubled time of pandemic, which hopefully we might see the end soon. Regards,

GillesArcas commented 3 years ago

Drago.zip Hi, thanks for all the work, analysis and suggestions. I have compiled an exe file with another version of the IDE. 4.30 and 4.31 have been compiled with a French IDE while previous version were compiled with an English version. Cannot test if it fixes the problem but it is worthy to try. Tell me.

comiluv commented 3 years ago

I'm afraid the problem persists. I also found out that the problem I described above that there's "fallback" to untranslated English, and that getting repetition of untranslated and broken strings together in a same menu item is due to Drago-Kr.lng file's line ending was in LF whereas it was necessary to be in CRLF. My text editor automatically did that when I saved the file. Even after re-saving Drago-Kr.lng file with line endings set to use CRLF, latest version still shows broken text messages, although now it doesn't show fallbacks to default English or repetitions.

CRLFlineending

I should probably also mention version 4.23 renders both translations correctly regardless of differences in line endings.