Closed lrineau closed 7 years ago
Hi Gilles,
The recent modifications broke code.
First, the use of QOpenGLWidget
in libQGLViewer-2.7.0 made it require Qt-5.4 or later. It seems libQGLViewer-2.6.4 was documented as compatible with any version of Qt4 or Qt5. I suggest that the changes of 2.7.0 make it clear there is a big change in the requirements.
Even with a recent Qt (5.7 from Fedora 25), there was a compilation error. This PR fixes that compilation issue, by adding
#include <QMap>
in camera.h
.
Now that you use Github, maybe you should use the Travis CI integration to make the new commits tested automatically with a few different versions of Qt.
- First, the use of QOpenGLWidget http://doc.qt.io/qt-5/qopenglwidget.html in libQGLViewer-2.7.0 made it require Qt-5.4 or later. It seems libQGLViewer-2.6.4 was documented as compatible with any version of Qt4 or Qt5. I suggest that the changes of 2.7.0 make it clear there is a big change in the requirements.
You're absolutely right. I didn't realize this.
- Even with a recent Qt (5.7 from Fedora 25), there was a compilation error. This PR fixes that compilation issue, by adding
thanks, merged
Now that you use Github, maybe you should use the Travis CI integration to make the new commits tested automatically with a few different versions of Qt.
I could, indeed. I never played with Travis, but I should google it.
Gilles
Tested on Fedora 25, with Qt 5.7.1.
(Cc @maxGimeno)