GillesDebunne / libQGLViewer

libQGLViewer is an open source C++ library based on Qt that eases the creation of OpenGL 3D viewers.
Other
241 stars 94 forks source link

Make QGLViewer compile with Qt6 #55

Closed bjornpiltz closed 2 years ago

bjornpiltz commented 2 years ago

Here are the changes I needed to update my QGLViewer based project to Qt 6.

The changes are non-intrusive and should work with Qt.5.4 and above (at least).

bjornpiltz commented 2 years ago

BTW, I only tested with MSVC 2019 and Qt 6.2 and 5.15.2.

GillesDebunne commented 2 years ago

Thanks a lot for this contribution! I'll have a look shortly

Gilles

On Wed, Oct 20, 2021 at 2:28 PM bjornpiltz @.***> wrote:

BTW, I only tested with MSVC 2019 and Qt 6.2 and 5.15.2.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/GillesDebunne/libQGLViewer/pull/55#issuecomment-947616281, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOPFGRAPVRJ6Y46TLOPTJ3UH2YVVANCNFSM5GLQLHTA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

GillesDebunne commented 2 years ago

Hello,

This late message to warn you that I just created a qt6 compatible version using your changes. Thanks a lot for your contribution

Gilles

On Fri 22 Oct 2021 at 10:14 Gilles Debunne @.***> wrote:

Thanks a lot for this contribution! I'll have a look shortly

Gilles

On Wed, Oct 20, 2021 at 2:28 PM bjornpiltz @.***> wrote:

BTW, I only tested with MSVC 2019 and Qt 6.2 and 5.15.2.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/GillesDebunne/libQGLViewer/pull/55#issuecomment-947616281, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOPFGRAPVRJ6Y46TLOPTJ3UH2YVVANCNFSM5GLQLHTA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.