GillesDebunne / libQGLViewer

libQGLViewer is an open source C++ library based on Qt that eases the creation of OpenGL 3D viewers.
Other
245 stars 94 forks source link

Compilation issue on Visual Studio 16 2019 #67

Open kerautret opened 1 year ago

kerautret commented 1 year ago

By testing to use libQqGLViewer on VS 2019, I get this issue. I tried different fix following other operator but no success. I am perhaps missing something.

VRender\Primitive.cpp(121,24): error C2039: '<<': is not a member of 'vrender' [C:\projects\libqglviewer\QGLViewer\qglviewer.vcxproj] 632 C:\projects\libqglviewer\QGLViewer\VRender\Primitive.h(20): message : see declaration of 'vrender' [C:\projects\libqglviewer\QGLViewer\qglviewer.vcxproj] 633 PrimitivePositioning.cpp 634 TopologicalSortMethod.cpp 635 VRender.cpp 636 Vector2.cpp 637 Vector3.cpp 638 1>VRender\Vector3.cpp(111,24): error C2039: '<<': is not a member of 'vrender' [C:\projects\libqglviewer\QGLViewer\qglviewer.vcxproj] 639 C:\projects\libqglviewer\QGLViewer\VRender\NVector3.h(7): message : see declaration of 'vrender' [C:\projects\libqglviewer\QGLViewer\qglviewer.vcxproj]

kerautret commented 1 year ago

if @GillesDebunne have an idea of fix ;)

GillesDebunne commented 1 year ago

From what I understand, this problem only occurs when building with C==14 and/or c++17 option flag? If that's the case, can you update the title accordingly?

I do not have access to a Visual Studio compiler, but I could try to reproduce using gcc with proper options

kerautret commented 1 year ago

I am not sure in fact, we were needed to change the default VC version in appveyor configuration in order to activate C++17 but the target of the C++17 was to compile other lib/tools. So perhaps no link to C++17. (I was letting the default qmake configuration).

bjornpiltz commented 1 year ago

Does https://github.com/GillesDebunne/libQGLViewer/pull/71 this fix the problem?

DELICATE959 commented 1 year ago

Does #71 this fix the problem?

yes!

bjornpiltz commented 1 year ago

Great! #71 has been superseded by #80, which also adds a MSVC2019 build job to the CI.