About nested class deserializing

JStudio commented 4 years ago

Hi @GillianPerard , I'm Ash in Korea.

I'm interested in your json-serializer, it is a great product I have ever seen it in Typescipt.

And I wonder if I use it correctly, it can't deserialize the case of nested class.

import { Serializable, JsonProperty } from 'typescript-json-serializer';
import { SR_Status } from './SR_Status';
import { ContentEntry } from './ContentEntry';

@Serializable()
export class GetContentEntries_2C_1 {

    public readonly ID: string  = "GetContentEntries.2C.1";

    @JsonProperty("id")
    public id: string;

    @JsonProperty("st")
    public status: SR_Status;

    @JsonProperty({ name : "es", type: ContentEntry })
    public entries: Array<ContentEntry>;

    public constructor() {
        this.id = this.ID;
        this.status = new SR_Status();
        this.entries = new Array<ContentEntry>();
    }
}

//deserialize
const m = deserialize<GetContentEntries_2C_1>(msg,GetContentEntries_2C_1);  

//result
id: string; 
entries : object
status : object

When I try to deserialize this class,

"this.entries" and "status" remained just an object.

So I need to deserialize with each type again.

Could you let me know, it is the intended way or what am I missing something?

Thanks for your cool product.

GillianPerard commented 4 years ago

Hi! I really appreciate you use and like my lib 😊

Let me check what happened, could you just provide me the msg object as well please, to be sure to reproduce exactly the case.

JStudio commented 4 years ago

@GillianPerard Thanks for your reply! Here is msg object.

GillianPerard commented 4 years ago

You did not provide me your subclasses like ContentEntry or SR_Status but I think you miss to set these classes Serializable and use the JsonProperty on each of their properties 😊

@Serializable()
class SR_Status {
    @JsonProperty() c: number;
    @JsonProperty() m: string;
}

@Serializable()
export class PS {
    @JsonProperty() scene: string;
    @JsonProperty() rev: string;
    @JsonProperty() version: string;
    @JsonProperty() leaderboard: string;
}

@Serializable()
export class ContentEntry {
    @JsonProperty() ty: string;
    @JsonProperty() no: number;
    @JsonProperty() tit: string;
    @JsonProperty() st: string;
    @JsonProperty() ps: PS;
    @JsonProperty() sin: number;
    @JsonProperty() pop: number;
    @JsonProperty() tpc: number;
    @JsonProperty() twa: number;
    @JsonProperty() mwa: number;
    @JsonProperty() ftm: number;
    @JsonProperty() ltm: number;
}

@Serializable()
export class GetContentEntries_2C_1 {
    public readonly ID: string = 'GetContentEntries.2C.1';

    @JsonProperty('id')
    public id: string;

    @JsonProperty('st')
    public status: SR_Status;

    @JsonProperty({ name: 'es', type: ContentEntry })
    public entries: Array<ContentEntry>;

    public constructor() {
        this.id = this.ID;
        this.status = new SR_Status();
        this.entries = new Array<ContentEntry>();
    }
}

const m = deserialize<GetContentEntries_2C_1>(msg, GetContentEntries_2C_1);

This is just an example, you have to verify the classes 😊

JStudio commented 4 years ago

Thanks for your answer!

It works well, I missed the @Serializable() on sub class.

You saved my day! you're a genius

GillianPerard commented 4 years ago

I'm happy it works and again thanks a lot for your compliments and especially to use my lib 😊.

GillianPerard / typescript-json-serializer

About nested class deserializing #82