Gilly7CE / Carpet-Addons-Not-Found

Addons for the Fabric Carpet mod
MIT License
6 stars 0 forks source link

[RULE] - setStackSize item_name stack_size #107

Open DH12043 opened 1 year ago

DH12043 commented 1 year ago

setStackSize

Be able to set a custom stack size for any item in the game, independently controlled for each item type

options:

item_name: select the item you wish to modify the stack size for (shows a list with all items) stack_size: choose 1, 16, 64, or custom int for the max stack size It also needs to have the ability to list any modified sizes and reset all to the default

Gilly7CE commented 1 year ago

This feels less like a carpet rule and more like an actual carpet feature. It could be it’s own command with its own config.

The carpet rule API is limited to boolean, string and enum types (if I remember correctly). So I’m more convinced this would be its own genuine feature purely from the implementation details. The string type might work but we’d still need to do custom parsing, and we’re need a listener on the rule all the time so we invoke the correct behaviour. Which I think could get too complicated easily

The “rule” part can just be enabling or disabling this feature

Gilly7CE commented 1 year ago

This issue can be worked on once 1.3.0 is released.

Gilly7CE commented 1 year ago

Moving to 1.3.0 since @DH12043 wants to work on it.

Gilly7CE commented 1 year ago

Removing the milestone 1.4.0 as this can just be included in whatever minor version is next once it is complete