[BUG] - Compatibility issue with other mod due to `PhantomSpawnerMixin.isSpectatorCreativeOrAtMobCap`

[Gilly7CE]

Description

A user found their client crashing everytime they try to load a singleplayer world. The issue looks like a mod compatibility issue. Suspect a redirect exists for for the PhantomSpawner class which targets the same method we do. The exception thrown has this info:

Caused by: org.spongepowered.asm.mixin.injection.throwables.InjectionError: Critical injection failure: Redirector isSpectatorCreativeOrAtMobCap(Lnet/minecraft/class_1657;)Z in gilly7ce-carpet-addons.mixins.json:PhantomSpawnerMixin from mod gilly7ce-carpet-addons failed injection check, (0/1) succeeded. Scanned 1 target(s). Using refmap gilly7ce-carpet-addons-refmap.json

For more info, refer to the attached crash report.

To Reproduce

Run 1.18.2 version of the game with the mods loaded (see crash report file) and create/load a singleplayer world. Game crashes when trying to load the world.

Expected behaviour

The mod should not be causing the client to crash.

Version

• Minecraft version: 1.18.2
• Carpet version: 1.4.69
• Mod version: 1.1.0

Additional notes

Need to test this for 1.17.1, 1.18.2, 1.19.3 and 1.19.4 too. If the issue is affecting 1.19.4 (main branch) then work needs to target 1.19.4.

crash-2023-05-28_18.16.45-server.txt

[Gilly7CE]

Suspect it is essential addons mod because that has its own phantomsObeyMobcaps rule.

[Gilly7CE]

Can confirm it is essential addons.

[Gilly7CE]

Fix will be introduced into all versions since this will always clash when essential addons is updated.