search

Gilly7CE / Carpet-Addons-Not-Found

Addons for the Fabric Carpet mod
MIT License
6 stars 0 forks source link

[BUG] - `dropEyesOfEnderFromEndPortalFrame` does not work on release build #181

Closed Gilly7CE closed 1 year ago

Gilly7CE commented 1 year ago

Description

When the rule dropEyesOfEnderFromEndPortalFrame is enabled, right clicking the portal frame does not work as intended. The end portal frame doesn't

To Reproduce

Steps to reproduce the behavior:

  1. Set dropEyesOfEnderFromEndPortalFrame to true
  2. Go to a full end portal frame
  3. Right click it
  4. See no eye of ender drop

Expected behavior

The eye of ender should drop as an item, making the portal frame empty and break any portals if connected.

Version (please complete the following information):

Gilly7CE commented 1 year ago

Weirdly it's working in the dev build. When I used it on my 1.20.1 client it did not work. Will investigate.

Gilly7CE commented 1 year ago

Might be a mod clash

Gilly7CE commented 1 year ago

I'm going insane. It works with all the same mods in the dev build. I might need to just re-install my client or the mod on my side, see if that fixes it.

Gilly7CE commented 1 year ago

Think I found the issue. The mixin is missing some annotations on the method which might be okay whilst in dev mode but the actual build doesn't work.

Gilly7CE commented 1 year ago

Can confirm that the build .jar doesn't have the rule working.

Gilly7CE commented 1 year ago

Fix is to ensure the class is properly overriding the base class for the target method.

Gilly7CE commented 1 year ago

This change will need to be ported to other versions as code is same between each.