search

Gilly7CE / Carpet-Addons-Not-Found

Addons for the Fabric Carpet mod
MIT License
6 stars 0 forks source link

[RULE] - Disable mob spawning per dimension #91

Closed Gilly7CE closed 1 year ago

Gilly7CE commented 1 year ago

Proposed rule name

Three rules:

Describe rule

Mob spawning can be disabled in its entirety per dimension. Could be useful for creative testing of farms without disabling mob spawning as a whole with the gamerule. These should be given the CREATIVE category.

Options for rule

true or false (default)

connorslade commented 1 year ago

Would it be better to have just mobSpawningInOverworld, mobSpawningInNether, and mobSpawningInEnd with a default value of true?

Gilly7CE commented 1 year ago

Would it be better to have just mobSpawningInOverworld, mobSpawningInNether, and mobSpawningInEnd with a default value of true?

The standard definitions for rules is that they modify the vanilla behaviour, so they’re always by default false. If we make the default behaviour true and use the rule names as you mention then that would break the pattern and it would read as carpet rules are enabled, which would technically be not the case. “disable” is explicitly clear what we intend.

connorslade commented 1 year ago

A few rules in base carpet are true by default like creativePlayersLoadChunks, fillUpdates, interactionUpdates, and many more in rule expansion mods. So I don't think it would be that bad to have them true by default. I generally prefer the enable rules over disable ones, but a default value of false is ok.

As for the name, the default carpet rules that disable a vanilla feature when true seem to be in the format of ...Disabled (antiCheatDisabled, liquidDamageDisabled). Should this format be used for these rules too?

Gilly7CE commented 1 year ago

A few rules in base carpet are true by default like creativePlayersLoadChunks, fillUpdates, interactionUpdates, and many more in rule expansion mods. So I don't think it would be that bad to have them true by default. I generally prefer the enable rules over disable ones, but a default value of false is ok.

As for the name, the default carpet rules that disable a vanilla feature when true seem to be in the format of ...Disabled (antiCheatDisabled, liquidDamageDisabled). Should this format be used for these rules too?

Good points. However, we already have rules which start with disable… and consistency within the mod itself is also an important consideration