search

Gilly7CE / Carpet-Addons-Not-Found

Addons for the Fabric Carpet mod
MIT License
6 stars 0 forks source link

[BUG] - `creativePlayerOneHitKill` destroys filled item frame before popping/destroying the item inside it #92

Closed Gilly7CE closed 1 year ago

Gilly7CE commented 1 year ago

Describe the bug

When creativePlayerOneHitKill is enabled and the player left clicks a full item frame, it destroys it entirely instead of destroying/popping the item first.

To Reproduce

Enabled creativePlayerOneHitKill, go to creative mode, place an item frame on a block and place an item in it. Left click the item frame and it is destroyed.

Expected behavior

Left clicking should remove the item from the frame

Version

Gilly7CE commented 1 year ago

Potential fix would be to ignore item frame entities in the mixin.

Gilly7CE commented 1 year ago

Need to test if this affects 1.18.2 & 1.19.4. 1.17.1 not applicable as rule not there.