Gilly7CE / Carpet-Addons-Not-Found

Addons for the Fabric Carpet mod
MIT License
6 stars 0 forks source link

[MC VERSION] - Support for 1.20 #99

Closed Gilly7CE closed 1 year ago

Gilly7CE commented 1 year ago

We shall need to support 1.20 once it is released. Work on this should begin once carpet 1.20 has been released.

Additions to existing rules we will need:

Gilly7CE commented 1 year ago

Also look at spectatorPlayersUsePortals as an offset is added which I suspect has been removed for 1.20 now.

Serzbiedry commented 1 year ago

Why no branch for this yet? :p

Gilly7CE commented 1 year ago

Why no branch for this yet? :p

Because I’m waiting for the full carpet 1.20 (not pre release versions) plus it will be what main becomes. I’ll need to create a 1.19.4 from main 😛

Gilly7CE commented 1 year ago

1.20 update will release on June 7th, so need to create 1.20 branch then, or after.

Gilly7CE commented 1 year ago

1.20.x branch will be created from the 1.19.4 branch.

Gilly7CE commented 1 year ago

This branch will always be the latest version of 1.20. Once a patch version of 1.20 is released, support for the previous one is dropped.

Gilly7CE commented 1 year ago

Rules now broken:

Gilly7CE commented 1 year ago

replaceableFlowers was a false alarm since I simply cannot code

Gilly7CE commented 1 year ago

Another false alarm with alwaysPickFlowersFromPots. Do not understand what happened there.

Gilly7CE commented 1 year ago

Also look at spectatorPlayersUsePortals as an offset is added which I suspect has been removed for 1.20 now.

Offset still needed to go through a single nether portal block. I think the new change is to the camera position only, not the bounding box of the spectator player