search

Gilnaa / globwalk

MIT License
47 stars 14 forks source link

Bump bitflags dependency by major version to 2 #34

Closed ds-cbo closed 9 months ago

mightyiam commented 9 months ago

Thank you. I hope the author responds.

Gilnaa commented 9 months ago

I apologize for the delay, I appreciate the effort. I assume that the dependency o an old version of bitflag caused some pain, curious to hear some details.

mightyiam commented 9 months ago

Thank you for getting 'round to it. It's not a big deal. It's to avoid having multiple versions of the same crate. The way I found out was this lint. It's included in pedantic.

And then I used cargo tree --duplicates. Really nice tooling we have.

ds-cbo commented 9 months ago

I assume that the dependency [of] an old version of bitflag caused some pain, curious to hear some details.

The pain is in compile time. In our dependency tree we had both bitflags 1.x and 2.x and both were somewhat slow to compile, so I went around all our dependencies using 1.x to update them.

I used the same lint and command as @mightyiam mentioned, and it's helped us (with a heavy project) bring down compile times by a fair margin. It's also often suggested in blog posts looking at decreasing compile times that getting rid of duplicate dependencies can be a quick/easy win.

So, thanks a lot for the merge!