Gilnaa / memoffset

offsetof for Rust
MIT License
224 stars 29 forks source link

Fixed build for old nightlies where doctests were not present. #32

Closed Gilnaa closed 4 years ago

Gilnaa commented 4 years ago

Tested with nightly-2017-09-01 which was just after 1.20 was released.

The 1.40 version comparison currently doesn't work, since the nightly 1.40 compiler equates lower than Version::from((1, 40, 0)). This shouldn't be a problem once 1.41 nightly compilers are available.

RalfJung commented 4 years ago

the nightly 1.40 compiler equates lower than Version::from((1, 40, 0))

That seems like a bug?

Gilnaa commented 4 years ago

I don't think so, 1.40-nightly does predate 1.40-stable. I'm okay with this situation since not all 1.40 nightlies support doctest and 1.41 should be out any minute now