some reorganization - Githubissues

Gilnaa / memoffset

offsetof for Rust

MIT License

224 stars 29 forks source link

some reorganization #44

Closed RalfJung closed 4 years ago

RalfJung commented 4 years ago

Move raw_field! to its own file, and extract the "create raw ptr" part into a sub-macro so that all the rest of the code can be shared.
Use raw_field! in span_of!. This means we do not even need the field check as a separate macro any more.
Extract the ptr-diff computation in a sub-macro so that offset_of! is always the same macro, just its sub-macros differ depending on compiler version and feature flags.

RalfJung commented 4 years ago

The nightly failure is weird, it is for some reason using a nightly from a weak ago that does not have ptr::raw_const! yet... seems like a Travis issue? Maybe it's better now on the re-run.

Gilnaa commented 4 years ago

Nice. Can we merge this?

Should I upload a new version?

RalfJung commented 4 years ago

Nice. Can we merge this?

I think so. :)

Should I upload a new version?

Sure, why not. It should be fully compatible.