search

Gilnaa / memoffset

offsetof for Rust
MIT License
224 stars 29 forks source link

Release with inclusion of builtin addr_of! macro use #51

Closed est31 closed 3 years ago

est31 commented 3 years ago

It would be cool to get a release out which includes #50 , now that 1.51 is released.

RalfJung commented 3 years ago

FWIW, I also have the permissions to do a release, but @Gilnaa usually does it so I'd be more likely to make a mistake in the process. ;)

Gilnaa commented 3 years ago

I have a reminder to do it later today :)

@ralfjung do you think we should release 1.0.0 now that UB is abolished?

RalfJung commented 3 years ago

I'd say for now just make a patch release as usual. That also ensures that everyone gets the update, since it is semver-compatible.

If no problem comes up for a while, we can do another thorough review and then call it 1.0.

est31 commented 3 years ago

A patch release would have the advantage of getting faster to users. They just have to cargo update, instead of people having to update it manually, sometimes deep in the dependency hierarchy.

Gilnaa commented 3 years ago

Okie dokie, all done, version v0.6.2 published to crates.io :)

RalfJung commented 3 years ago

Thanks a lot. :-)