Gimly / vscode-matlab

MATLAB support for Visual Studio Code
MIT License
180 stars 35 forks source link

Matlab file icon #62

Open jxramos opened 5 years ago

jxramos commented 5 years ago

I'm not sure if this is under the purview of a vscode extension, but if its possible I'd love to see the icon you use for the extension itself to also be used for the .m files, possibly .mat files too.

I'm not sure if it could be pulled off but using the same icons as the Matlab desktop GUI would be a big win too, but that may be too Matlab specific and fail to immediately communicate these are m files. This would be important since people wouldn't run Matlab from VSCode but edit in there, so having a language to language differentiating icon would be better than just the simple fx icon the Matlab gui uses.

image

This is the sort of thing I'm talking about, examining a file under the sidebar. You see that m files default to the generic text icon like the gitCommitMsg.txt does. Notice that the python and json files each have their own distinctive icons. This would make the readability of the Matlab source pop out a lot in a heterogeneous language codebase.

matlabfileicon

rick3rt commented 5 years ago

The vscode-icons extension has a Matlab icon:

image

No .mat file support though, and also no difference between functions, scripts and classes.

timfelle commented 4 years ago

The vscode-icons extension has a Matlab icon:

image

No .mat file support though, and also no difference between functions, scripts and classes.

I use Material Icon Theme, and there it is possible to overwrite file associations with a setting, that might help with the .mat extension, and i am quite sure vscode-icons should have such an overwrite setting as well.

The setting from Material Icon Theme: "material-icon-theme.files.associations": { "*.m": "matlab", "*.mat": "matlab", }

thisisbipin commented 3 years ago

I feel this is an old question but then too you can do this by going to the file material-icons.json which is in this extension folder and just modify the fileExtensions section by adding "mat":"matlab", it will work since 'matlab' is already added in icons definition. screenshot

ghost commented 3 years ago

I prefer the aesthetic of https://raw.githubusercontent.com/PKief/vscode-material-icon-theme/main/icons/matlab.svg - same color as text ofc

ghost commented 2 years ago

The appropriate thing to do is to implement the new fallback language icon proposal at microsoft/vscode#140047

I'll open a pull for it

<svg version="1.1" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg">
<path d="m15.94 2.33c-.12 0-.24.06-.36.18-.1.07-.23.18-.52.41-.6.48-2.33 3.34-3.26 4.31-.82.86-1.15.41-2 1.12-.86.72-2.18 2.15-2.18 2.15l2.13 1.58 3.38-4.65c.27-.37.45-.64.58-.87-.47 1.25-1 2.62-1.63 3.86-1.82 3.58-5.41 5.89-5.41 5.89.61.27 1.16.16 1.81.78.45.54 1.74 3.2 2.51 4.87 0 0 .63-.34 1.43-.92.8-.58 1.77-1.4 2.45-2.34.9-1.26 1.6-2.03 2.19-2.51.59-.47 1.08-.65 1.55-.69 1.67-.14 4.15 2.86 4.15 2.86s-5.19-16.02-6.83-16.03zm.06 2.34c.14.27.26.43.42.78.68 1.43 1.48 3.42 2.22 5.4.67 1.78.76 2.14 1.25 3.57-.44-.15-.84-.37-1.4-.32-.72.06-1.55.38-2.31.99-.76.61-1.52 1.48-2.46 2.79-.53.74-1.4 1.49-2.13 2.02-.01.01-.01.01-.02.01-.24-.5-.45-.96-.69-1.44-.49-.96-.78-1.64-1.3-2.28l-.06-.07-.06-.06c-.03-.03-.07-.03-.1-.06 1.29-1.1 2.84-2.68 3.99-4.95.95-1.88 1.67-3.95 2.26-5.5.15-.39.26-.59.39-.89zm-9.02 6.33-5.23 1.92 4.04 2.86 3.23-3.19-2.04-1.59zm-.25 1.6.15.12-1.24 1.23-.88-.62 1.97-.72z" fill-rule="evenodd" />
</svg>