search

Gimly / vscode-qlik

This extension adds support for Qlik scripting to VS Code.
MIT License
26 stars 18 forks source link

Highlight Drop Statement #2

Closed cmendesfirmino closed 6 years ago

cmendesfirmino commented 6 years ago

Hi, I've just notice that the drop statment is not too correct. Drop table and Drop Field are ok but Drop Tables and Drop Fields. I read the code qvs.tmLanguage and made a correction.

<key>comment</key>
<string>DROP statement</string>
<key>match</key>
<string>(?i:^\s*(drop)\s+(table[s]?|field[s]?))</string>
<key>name</key>
<string>meta.drop.qvs</string>

There are some highlights to correct too like RENAME, DO UNTIL ... LOOP, INNER JOIN, RIGHT JOIN, OUTER JOIN.

Thanks

Gimly commented 6 years ago

Hi @cmendesfirmino thanks for the heads-up! Since you already did the change, you can create a pull request and I'll happily merge it, this way I don't "steal" your work 😄 and you'll be a contributor.

cmendesfirmino commented 6 years ago

Hi @Gimly, so I gonna to make these improviments before pull request. I'm glad to contribute with this helpful project.

Thanks