GinRex / twitterClone

Assignment week 3
0 stars 0 forks source link

Twitter Clone - Assignment coderschool week 3 #1

Open GinRex opened 8 years ago

GinRex commented 8 years ago

I got some problems trying commit code via terminal using Ubuntu (it can't upload some res so i had to upload myself). Hopefully, it works well :D please review it.

/cc @coderschoolreview /cc @hoanle

hoanle commented 8 years ago

:+1: Nice work. A few notes after checking out the code:

TextView tvName = holder.tvName;
        TextView tvBody = holder.tvBody;
        ImageView userPPic = holder.userProfilePic;
        ImageView ePic = holder.epic;
        TextView tvTime = holder.tvDateago;
        TextView like = holder.tvLike;
        TextView share = holder.tvShare;

You can use holder.tvName directly

Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, ActionBar, Navigation, Models, Authentication, API Communication, Persistence, et al) and see how they all fit together. We are close now to a turning point in the course where you should be hitting a "critical mass" towards your knowledge of Android.