Twitter Clone - Assignment coderschool week 3

[GinRex]

updated some new features for HW4, please review it. /cc @coderschoolreview /cc @hoanle

[hoanle]

@GinRex : Can't find the class ComposeDialogFragment

[hoanle]

:+1: nice work. A few notes after checking out the code:

• In the future, definitely consider additional polish for the UI by reviewing the cloning a screen tutorial and Q&A and the drawables guide. For example, the Love Tweet image can be put into 1 Drawable selector. Do not need to set on runtime manually
• Nice to see you played around with styling the sliding tab strip
• Remember to add an indeterminate progress indicator during background tasks. And remember to hide the progress bar of Pull-to-refresh. Now it's always shown after pull
• Correctly and appropriately used OnClickListeners on the user's profile image to navigate to their profile view. Unfortunately, Reply, Retweet have not been implemented. ReplyTweetDialogFragment just shows detail? No action?
• Good to see you properly communicated the user to the user timeline fragment from the profile activity.
• Glad to see you properly hooked up each of the different timelines to infinitely paginate.
• Nicely done architecting the fragments (base class and extension classes) such that you put as much code and logic as possible in the base class and then used abstract methods to define only the specific behavior where they differ!

-In your group project: You MUST use Gson. No more manually parsing it.

• In ComposeDialogFragment, you still manually find view by id, use Butterknife consistently
• Remove unused/commented code, it causes reader confused

... Here's a detailed Project 4 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.

This week (Week 5), we are going to cover the last major piece to the Android puzzle and that is using the hardware and SDK components such as the camera, photo gallery, location, maps, etc. After that, Week 6 and week 7 we will be covering a few important intermediate topics such as more about styling and animation as well as testing.

Following the bootcamp, we are going to have a public demo day to celebrate the progress you've all made with our next batch of Android students and multiple companies attending to see the group projects that you all have built. We are going to help however we can over the next few weeks to get the team project apps in shape for that.