Giners / mui-places-autocomplete

Google Material Design (Material-UI) styled React component using Google Maps Places Autocomplete
MIT License
34 stars 26 forks source link

Ability to override and pass additional props to the suggestions container #41

Closed robinknox closed 2 years ago

robinknox commented 6 years ago

This change will allow users of this component to control the props on the Popper component. Therefore they can now control the width of the suggestions rendered to the screen as well as make a number of other custom modifications.

This should resolve issue https://github.com/Giners/mui-places-autocomplete/issues/40

robinknox commented 6 years ago

With regards to the build failing, this also appears to be happening in the master branch. Is it possible that the Google API utilised for the CD pipeline is no longer being accepted by Google?

robinknox commented 6 years ago

Hi @Giners do you have time to have a look over my pull request?

robinknox commented 6 years ago

Hey @Giners just bumping on this pull request to see if you have time to look it over.

yosefprogramming commented 5 years ago

@Giners Hey this would really be a useful feature to use. Please look over it.

daniel-bogdoll commented 5 years ago

@Giners Please take a look :)

Giners commented 5 years ago

Hi @slisystem,

I'm terribly sorry I haven't checked this out. Life got crazy and overwhelming. I'm trying to get back into the swing of things now. I appreciate you using this component and putting this PR up. I will try to get to this ASAP.

I think the first thing I need to address are the failing tests. Without them no PR will get merged in even if I approve.

And again I would like to apologize to you @slisystem and @robinknox.