Closed GokulBothe99 closed 2 months ago
This update simplifies the handling of local data in the runset execution workflow by removing unnecessary deletion logic after a successful upload. It introduces a conditional check to ensure local data is only deleted if the execution report has been successfully stored in a centralized database. These changes enhance the robustness of the logging and data management processes, preventing potential data loss.
Files | Change Summary |
---|---|
Ginger/GingerCoreNET/Run/RunListenerLib/CenteralizedExecutionLogger/AccountReportExecutionLogger.cs Ginger/GingerCoreNET/Run/RunsetExecutor.cs |
Removed local data deletion logic from RunSetEnd in AccountReportExecutionLogger . Added checks in RunRunset to delete local data only if the report is successfully stored remotely, improving data management and preventing data loss. |
sequenceDiagram
participant User
participant RunsetExecutor
participant AccountReportExecutionLogger
User->>RunsetExecutor: Start Runset
RunsetExecutor->>AccountReportExecutionLogger: RunSetEnd()
alt Report stored successfully
AccountReportExecutionLogger-->>RunsetExecutor: Success
RunsetExecutor->>RunsetExecutor: Check delete local data
alt Config allows deletion
RunsetExecutor->>RunsetExecutor: DeleteLocalData()
end
else Report storage failed
AccountReportExecutionLogger-->>RunsetExecutor: Failure
end
🐇 In a meadow so bright, with changes in flight,
Local data now safe, oh what a delight!
With reports stored away in the cloud up high,
No more worries, we leap and we sigh.
Hooray for the updates, let’s hop and let’s play,
For a smoother tomorrow, hip-hip-hooray! 🌼✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Thank you for your contribution. Before submitting this PR, please make sure:
Summary by CodeRabbit
New Features
Bug Fixes