search

GingerBear / vscode-liquid

vscode liquid language support
MIT License
26 stars 9 forks source link

[0.1.0] Syntax and highlighting bug #16

Closed jonathanmoore closed 5 years ago

jonathanmoore commented 5 years ago

With the release of 0.1.0, syntax highlighting is broken with basic HTML inside liquid files. I'm not fully up to speed on VS extensions, but the following lines are the cause. Testing locally and removing those lines fixes the issue and everything highlights as expected. https://github.com/GingerBear/vscode-liquid/blob/master/syntaxes/liquid.tmLanguage#L63-L70

My assumption is that the CSS and JS syntax and reserved words are kicking in throughout the entire file with certain characters and throwing off the rest of the highlighting.

image

0.0.3 Highlighting

image

0.1.0 Highlighting

image

Related issue: #11

GingerBear commented 5 years ago

thanks for the feedback, I just reverted the commit that cause this issue and published a new version.