Gingerbeard5773 / Shiprekt

A King Arthurs Gold mod with top-down naval combat.
2 stars 5 forks source link

improved couplings #188

Closed Gingerbeard5773 closed 10 months ago

Gingerbeard5773 commented 10 months ago

couplings currently attempt to attach ships on collision, but this can cause problems when the coupling attempts to attach onto a corner of another block, as this is not allowed by the ship attachment system. the block is too far from the coupling, so the attachment fails, causing the coupling to slip through the block. this can potentially cause people to accidentally break ships and other issues. in general, docking is finicky because of this problem.

A better system would be to continuously check if the coupling can attach when the coupling is overlapping other blocks. it can be done by using the time frame between onCollision and onEndCollision, so that performance can be saved.

Introducing this system would allow for painless docking.

Gingerbeard5773 commented 10 months ago

completed. this is very good. couplings are very reliable now