search

GioBonvi / GoogleContactsEventsNotifier

Receive automatic email notifications before your Google Contacts birthday and other events!
MIT License
219 stars 50 forks source link

Updated German Translation #120

Closed peterberweiler closed 6 years ago

peterberweiler commented 6 years ago

I updated the German translation.

GioBonvi commented 6 years ago

Hi @shutdown27, thank you for submitting this PR!

As you are already working on this may I ask you to edit the translations of the following strings to be more similar to the original english version? The strings are: 'Work phone': 'Geschäftlich', 'Home phone', 'Main phone', 'Other phone'.

I'd particularly like if you could find us a translation conveying both the fact that we are talking about a telephone number and the type of number (something along the lines of "Telefonnummer (TYPE)", since I think 'Geschäftlich', 'Privat' etc. are just translations for "work", "home" etc. (please correct me if I'm wrong: it's been ages since I last studied german).

Thank you again for your time and patience

peterberweiler commented 6 years ago

@GioBonvi i updated it again, but i had trouble finding a good translation for main phone. Is a main phone the same as a landline phone? Because then "Telefon (festnetz)" would be a better fit.

GioBonvi commented 6 years ago

Yeah, I know some of these terms are not exactly easy to translate: the closest thing to a "definition" we have is this page where it says that "Main phone" is "the contact's main phone number". Additionally in italian it's translated as "Telefono principale", so "main" means the one you should be able to use to contact this person, the default one if you want, not necessarily a landline.

baatochan commented 6 years ago

In terms of translating phone names - isn't it better to check how it's translated by google? In google contacts you have this translated already.

GioBonvi commented 6 years ago

Yes, this could be a way to standardize the translation, although:

1) we would need to review all the old translations 2) at least in italian the translation displayed on contacts.google.com is just the phone type (e.g. "principale" for MAIN_PHONE, so we would need to explain to the translators they should take the phone type from there and append it to the word "phone" translated in their language 3) I think it's just not worth defining another set of rule to follow for such an ininfluent feature, instead we can check that everything looks ok when approving the PR and eventually direct the translator too look there for a confirmation.

This is what I think, but as always I am open to suggestions

peterberweiler commented 6 years ago

@baatochan that's exactly where i looked for inspiration. But there is nothing that resembles "main phone", we germans just don't have a word for main phone.

One alternative I have would be to change "home phone" to landline, which is "Telefon (festnetz)" and change "main phone" to "private phone", which would be "Telefon (privat)".

baatochan commented 6 years ago

I thought that all the English labels were somehow translated by Google. And while most ppl running our script in their language are using Google in the same keeping it consistent in some form like "phone (type)" is the way to make the least confusing. I'm not saying that we should make it as a rule and review all the translation, but we can encourage translators to follow that in new translations.