GioF71 / mpd-alsa-docker

Easily run mpd with Alsa or PulseAudio output with Docker. Upsampling 2x 4x 8x with "Goldilocks" settings by Archimago. Scrobbling support.
Apache License 2.0
20 stars 7 forks source link

Can you add the new environment variable for the **MixRamp** option? #380

Open GioF71 opened 9 months ago

GioF71 commented 9 months ago

Can you add the new environment variable for the MixRamp option? To analyze songs on-the-fly, the mixramp_analyzer option can be enabled in mpd.conf:

mixramp_analyzer "yes"

More info: https://mpd.readthedocs.io/en/latest/user.html#mixramp

Originally posted by @skierro in https://github.com/GioF71/mpd-alsa-docker/discussions/379

GioF71 commented 9 months ago

Hello, I might be wrong but the version tagged as 'v0.23.15' does not contain the needed changes. The next commit instead includes those changes. But I am building against the tag v0.23.15.

Have a look at this commit page:

https://github.com/MusicPlayerDaemon/MPD/commits/master/?after=c71e586c530e1d066efde7c2ca40c363f74100c7+139

The relevant commits:

Merge tag 'v0.23.15' <--- this is the first commit AFTER the tag 'v0.23.15' and does not have any tag https://github.com/MusicPlayerDaemon/MPD/tree/5f54a8e94edb95b4652af000da168ce238b2a96d

tag v0.23.15 <--- I am building this! https://github.com/MusicPlayerDaemon/MPD/tree/b8bfc986181a6824b7ee9c4f2c475369ca8ac931

If you check the differences, you will see that the changes needed to support mixramp_analyzer are not included in 'v0.23.15'. Unless I am missing something.

Can you confirm?

GioF71 commented 9 months ago

Hello, I am sorry, but the feature is not part of a release yet. From what I understand, it will not even be included in 0.23.x. The changes you request on the docker image have been implemented and are in a separate branch, of course there is an error now if you try to enable the feature, so I believe it's pointless to merge it. We need to wait for a release that includes the feature.

skierro commented 9 months ago

No problem. Let's wait for the official introduction of the feature in the next mpd release.