search

GioF71 / mpd-alsa-docker

Easily run mpd with Alsa or PulseAudio output with Docker. Upsampling 2x 4x 8x with "Goldilocks" settings by Archimago. Scrobbling support.
Apache License 2.0
20 stars 7 forks source link

Add support to have FFMPEG as a decoder for MPD #388

Closed nimda95 closed 6 months ago

nimda95 commented 6 months ago

Some streams are not supported by ffmpeg, specially when loading a radio that has only an m3u8 url via upnp.

GioF71 commented 6 months ago

Hello, thank you. Your changes look good. I would only ask you to check FFMPEG_ENABLED in the same way CURL_ENABLED is checked. It should become:

if [[ -z "${FFMPEG_ENABLED }" || "${FFMPEG_ENABLED ^^}" == "YES" || "${FFMPEG_ENABLED ^^}" == "Y" ]]; then ...

Eventually we can check that, if set, it must be Y/Yes, or N/No, but that's not done everywhere so I am not asking you to do that.

Also, for my own curiosity, can you point me to a stream that currently does not decode/play? Thnak you

GioF71 commented 6 months ago

Also please add an entry in the change history here

GioF71 commented 6 months ago

And probably last thing, in the readme, can you add your variable to the existing list? It's crowded I know, I must split somehow, but it's something for another ticket.

GioF71 commented 6 months ago

Included in https://github.com/GioF71/mpd-alsa-docker/pull/390

GioF71 commented 6 months ago

Please note that the plugin will be disabled by default. I just prefer to be safe, at least for a while. But I am going to activate it on my instances, so if everything is ok for a good while, the plugin might be enabled by default. Hope this is not a major inconvenience for you. Thank you for your contribution.