GioF71 / mpd-alsa-docker

Easily run mpd with Alsa or PulseAudio output with Docker. Upsampling 2x 4x 8x with "Goldilocks" settings by Archimago. Scrobbling support.
Apache License 2.0
18 stars 5 forks source link

Listenbrainz support? #391

Closed andrewgdunn closed 3 months ago

andrewgdunn commented 3 months ago

Would you consider adding this package so that we could get scrobbling directly to listenbrainz?

GioF71 commented 3 months ago

Hello, that is definitely interesting but I see there are no packages for debian/ubuntu. Anyway I can give it a try and maybe create a separate docker image for it. I am particularly worried about including another package in the image for the following reasons

Would a separate container image work for you?

andrewgdunn commented 3 months ago

Separate container image would be awesome!

There is already the (optionally) mpd-scribble application, something I don't already like: I'd prefer to keep one app per container

As some feedback I think that you should consider removing this from the image and have scrobbling be in "sidecar" containers like you're doing with mpd-subsonic-scrobbler

GioF71 commented 3 months ago

Separate container image would be awesome!

There is already the (optionally) mpd-scribble application, something I don't already like: I'd prefer to keep one app per container

As some feedback I think that you should consider removing this from the image and have scrobbling be in "sidecar" containers like you're doing with mpd-subsonic-scrobbler

Yes, I thought about it in the past, and in fact there is this image as well. I wonder if I will get issues opened if I remove the feature, even if I would be suggesting to use the other container... The problem is I don't know if anyone is using this addition inside mpd-alsa-docker!

GioF71 commented 3 months ago

Here: Repo.
Images are building now, unfortunately it's a slow process, about 1h. Will be waiting for your feedback!

GioF71 commented 3 months ago

Closing this as the repo is online and images are available. Will be waiting for your feedback for bug and/or feature requests. Cheers