search

GioF71 / mpd-alsa-docker

Easily run mpd with Alsa or PulseAudio output with Docker. Upsampling 2x 4x 8x with "Goldilocks" settings by Archimago. Scrobbling support.
Apache License 2.0
20 stars 7 forks source link

remove unnecessary root bash process when launch + fix CURL_PROXY proper substitution #407

Closed tantra35 closed 1 month ago

tantra35 commented 1 month ago

this patch solve 2 problems:

  1. it remove unnecessary bash as root process on top of mpd, so inside container mpd becomes process with PID=1
  2. fix CURL_PROXY wrong interpretation, for example without patch if we pass CURL_PROXY=http://192.168.88.1:3081, this setting will be completely ignored
GioF71 commented 1 month ago

Looks nice, let me test your changes. Thank you for your contribution. Especially about CURL_PROXY: I never use the setting so I didn't even notice the issue. About the other change, when you use "exec", what is the effect? Does bash quit after that call? Thanks a lot.

GioF71 commented 1 month ago

Found the answer about exec here, thanks, clever change.