search

GiordanoAgateRSE / SPHERA

SPHERA (RSE SpA): Lagrangian Computational Fluid Dynamics (LCFD) - Smoothed Particle Hydrodynamics (SPH) research code. Applications: subcatchment flash floods and fast landslides for the safety of hydroelectric plants, electrical substations and electricity pylons.
GNU General Public License v3.0
47 stars 41 forks source link

Fixed the first parameter of substations #6

Closed chqiao closed 5 years ago

chqiao commented 5 years ago

Fixed the first parameter of substations, which should be an integer (i.e., 0.0 -> 0).

ghost commented 5 years ago

Dear Qiao Cheng, many thanks for your correction. Unfortunately, the tutorial you refer is under revision: this 1-character “pull request” cannot be considered at the moment. Let me suggest you to notice me when you begin to work on a particular task related to SPHERA: this is not mandatory, but you would be granted to be the only person working on that topic and your associated pull requests would have priority. I apologize for the inconvenience. Many thanks again for your message. Have a nice day. Andrea

chqiao commented 5 years ago

Dear Andrea, Since the 0.0 represents a real number, it caused an error when I performed the calculation. So I checked the input parameters and fixed the issue by the way. I understand your explanation, thank you for your reminder. Have a nice day. Qiao Cheng

ghost commented 5 years ago

Many thanks Qiao Cheng, your correction ("0" instead of "0.") for tutorial on the Vajont was appreciated. This tutorial did not belong to the release SPHERA v.9.0.0 and was only tested with the ifort compiler, which bypassed the error. In any case that input line does not influence the output. You are right, the executable produced with the gfortran compiler prevent the execution. Feel free to propose again this correction at a later stage, as suggested in the previous comment. Have a nice day Andrea

chqiao commented 5 years ago

Dear Andrea, I only tested the Vajont example under ubuntu with gfortran, and I am very happy to do something helpful for SPHERA. I will try to propose the correction of this issue again at the right time, thank you. Have a nice day. Qiao Cheng