Giorgi / DuckDB.NET

Bindings and ADO.NET Provider for DuckDB
https://duckdb.net
MIT License
339 stars 61 forks source link

Conversions between DuckDBInterval and TimeSpan #114

Closed Seddryck closed 1 year ago

Seddryck commented 1 year ago

As discussed in #112 Close #111

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 5383170034


Changes Missing Coverage Covered Lines Changed/Added Lines %
DuckDB.NET/DuckDBNativeObjects.cs 22 24 91.67%
<!-- Total: 22 24 91.67% -->
Totals Coverage Status
Change from base Build 5379823364: 0.06%
Covered Lines: 757
Relevant Lines: 874

💛 - Coveralls
Seddryck commented 1 year ago

Not an expert in SonarQube but I don't think that the build pipeline is failing due to this change

Giorgi commented 1 year ago

@Seddryck Do you think we also need a method on DuckDBInterval that returns if it fits in TimeSpan or not? In case someone wants to filter items without getting exceptions.

Seddryck commented 1 year ago

@Giorgi,

Good call! I'll submit a new PR with your suggestion.