Giorgi / DuckDB.NET

Bindings and ADO.NET Provider for DuckDB
https://duckdb.net
MIT License
339 stars 61 forks source link

Consider changing DuckDBCommand.Prepare to noop instead of throwing NotSupportedException #118

Closed roee88 closed 12 months ago

roee88 commented 12 months ago

https://github.com/Giorgi/DuckDB.NET/blob/2cd0d80051db24500d57a273c5975f5ef6cb8f58/DuckDB.NET.Data/DuckDBCommand.cs#L108

When using abstractions like DbProviderFactory (or in the future DbDataSource) I think that it makes more sense to avoid throwing the exception here and allow it to pass through as a no operation. Otherwise, specialization for DuckDB commands is required.

Giorgi commented 12 months ago

@roee88 Can you send a PR?