#120 Connection string DataSource key is case sensitive

Giorgi / DuckDB.NET

Bindings and ADO.NET Provider for DuckDB

https://duckdb.net

MIT License

339 stars 61 forks source link

#120 Connection string DataSource key is case sensitive #130

Closed bykka closed 9 months ago

bykka commented 9 months ago

DataSourceKeys has got a new element "datasource"

Giorgi commented 9 months ago

Does it solve all the issues described in #120?

coveralls commented 9 months ago

Pull Request Test Coverage Report for Build 6215549499

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.688%

Totals
Change from base Build 6199373711:	0.0%
Covered Lines:	833
Relevant Lines:	955

💛 - Coveralls

bykka commented 9 months ago

You are right, forgot one more case to check

bykka commented 9 months ago

Could you, please, help to understand what is wrong with SonarCloud?

Giorgi commented 9 months ago

I don't think this is the right approach to use. What if somebody uses DaTasource or dataSource? The keywords in the connection string should be case insensitive and the parser should be aware of this.

bykka commented 9 months ago

tests are there. class ConnectionStringTests, lines 24, 25

Giorgi commented 9 months ago

Tests are failing.

bykka commented 9 months ago

My apologies. I have a problem running all tests locally - those fail because of "System.DllNotFoundException: Unable to load DLL 'duckdb' or one of its dependencies: The specified module could not be found. (0x8007007E)"

Tried to follow the steps from the ci.yml file but with the same result.

Giorgi commented 9 months ago

Can you make changes based on the comments I left?