Giorgi / DuckDB.NET

Bindings and ADO.NET Provider for DuckDB
https://duckdb.net
MIT License
339 stars 61 forks source link

Enable 'nullable' #145

Closed dev-gavinfang closed 9 months ago

dev-gavinfang commented 9 months ago

for #131

coveralls commented 9 months ago

Pull Request Test Coverage Report for Build 6428318505


Changes Missing Coverage Covered Lines Changed/Added Lines %
DuckDB.NET.Data/DuckDBCommand.cs 7 8 87.5%
DuckDB.NET.Data/Internal/ConnectionReference.cs 0 1 0.0%
DuckDB.NET.Data/Internal/ConnectionManager.cs 5 7 71.43%
DuckDB.NET.Data/DuckDBDataReader.cs 11 24 45.83%
<!-- Total: 32 49 65.31% -->
Files with Coverage Reduction New Missed Lines %
DuckDB.NET.Data/DuckDBConnection.cs 1 91.21%
DuckDB.NET.Data/DuckDBCommand.cs 2 82.81%
<!-- Total: 3 -->
Totals Coverage Status
Change from base Build 6420695333: -2.0%
Covered Lines: 922
Relevant Lines: 1079

💛 - Coveralls
dev-gavinfang commented 9 months ago

I'm not sure if adding nullability is worth it because of so many pragma statements.

it's ok. the PR was created when I tried to read the code, maybe it's not a good idea for now : )

Seddryck commented 9 months ago

I think I can submit a PR with some changes. nullable will help in the future to prevent some static mistakes. It's also a good way to pimp up some code from the first commits where some edge cases haven't been implemented.

Giorgi commented 9 months ago

@Seddryck That will be good but keep in mind that I merged another branch with large refactoring and there will probably be many conflicts from this PR.