Giorgi / DuckDB.NET

Bindings and ADO.NET Provider for DuckDB
https://duckdb.net
MIT License
339 stars 61 forks source link

chore: enable nullable compiling option #146

Closed Seddryck closed 9 months ago

coveralls commented 9 months ago

Pull Request Test Coverage Report for Build 6460281585


Changes Missing Coverage Covered Lines Changed/Added Lines %
DuckDB.NET.Data/DuckDBCommand.cs 14 15 93.33%
DuckDB.NET.Data/DuckDBParameter.cs 7 8 87.5%
DuckDB.NET.Data/Internal/ConnectionReference.cs 0 1 0.0%
DuckDB.NET.Data/VectorDataReader.cs 5 6 83.33%
DuckDB.NET.Data/Internal/ConnectionManager.cs 6 8 75.0%
DuckDB.NET.Data/DuckDBDataReader.cs 6 9 66.67%
DuckDB.NET.Data/DuckDBConnection.cs 10 22 45.45%
<!-- Total: 59 80 73.75% -->
Totals Coverage Status
Change from base Build 6455590535: -1.8%
Covered Lines: 899
Relevant Lines: 1023

💛 - Coveralls
Giorgi commented 9 months ago

I updated GetList not to use dynamic anymore. Can you resolve the conflicts? Thanks

Seddryck commented 9 months ago

PR refreshed with latest commits from your side

Giorgi commented 9 months ago

Merged, thanks @Seddryck