Giorgi / DuckDB.NET

Bindings and ADO.NET Provider for DuckDB
https://duckdb.net
MIT License
338 stars 61 forks source link

Implementation of the Connection.GetSchema of the DataSourceInformation collection #190

Open magneto-81 opened 1 month ago

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.73%. Comparing base (292bc55) to head (028df4d).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #190 +/- ## =========================================== + Coverage 88.38% 88.73% +0.35% =========================================== Files 54 54 Lines 1756 1802 +46 Branches 239 239 =========================================== + Hits 1552 1599 +47 + Misses 146 145 -1 Partials 58 58 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 9157409247

Details


Totals Coverage Status
Change from base Build 9156112100: 0.2%
Covered Lines: 1657
Relevant Lines: 1802

💛 - Coveralls
Giorgi commented 1 month ago

Is it possible to test it some other way? I.E what uses connection.GetSchema("DataSourceInformation")?

magneto-81 commented 1 month ago

Connection.GetSchema("DataSourceInformation") is used by generic software which, through the ado.net providers, allows its use. The information returned by this primitive is used to generate statements in a generic way (see for example DbMetaDataColumnNames.ParameterMarkerPattern).

Giorgi commented 1 month ago

Can you add a test that uses those APIs (that call Connection.GetSchema("DataSourceInformation")) under the hood to validate that it generates correct statements? That would increase the confidence of this change a lot.