search

Giorgi / DuckDB.NET

Bindings and ADO.NET Provider for DuckDB
https://duckdb.net
MIT License
338 stars 61 forks source link

Should the `RuntimeIdentifiers` property `osx` change to `osx-x64`? #201

Closed Cricle closed 2 weeks ago

Cricle commented 2 weeks ago

https://github.com/Giorgi/DuckDB.NET/blob/18decabf2e794881af4c566982aaa6ff4106eef0/DuckDB.NET.Bindings/Bindings.csproj#L7

https://github.com/Giorgi/DuckDB.NET/blob/18decabf2e794881af4c566982aaa6ff4106eef0/DuckDB.NET.Bindings/Bindings.csproj#L24

According to rid-catalog#macos osx-x64 is macOS RIDs

Cricle commented 2 weeks ago

Drafted modifications on #202

Giorgi commented 2 weeks ago

In that case I would need to have osx-x64 and osx-arm64 which probably means including libduckdb.dylib twice in the NuGet package.

Cricle commented 2 weeks ago

When use osx in RuntimeIdentifiers property in publish with AOT option will throw this error

Error NETSDK1082: Microsoft. NETCore. App does not have a runtime package available for the specified RuntimeIdentifier 'osx'

The public PortableRuntimeIdentifierGraph in here

https://github.com/dotnet/sdk/blob/cfab4700816a8ace11b9b700a1d85b721c363d6a/src/Layout/redist/PortableRuntimeIdentifierGraph.json#L317-L333

I don't know if this OSX identity will continue to be used in the future, If this is an unimportant matter, please close this issue.

Thanks.

Giorgi commented 2 weeks ago

I haven't looked into Native AOT yet. I'll close this issue and we can come back to it if needed.

Cricle commented 2 weeks ago

Ok